Remove command line definition of legacy EMSCRIPTEN macro#26417
Merged
sbc100 merged 1 commit intoemscripten-core:mainfrom Mar 16, 2026
Merged
Remove command line definition of legacy EMSCRIPTEN macro#26417sbc100 merged 1 commit intoemscripten-core:mainfrom
EMSCRIPTEN macro#26417sbc100 merged 1 commit intoemscripten-core:mainfrom
Conversation
sbc100
force-pushed
the
remove_EMSCRIPTEN
branch
5 times, most recently
from
4c32664 to
ce1f9f6
Compare
sbc100
force-pushed
the
remove_EMSCRIPTEN
branch
from
ce1f9f6 to
6e7b3bf
Compare
sbc100
changed the title
EMSCRIPTENEMSCRIPTEN macro
dschuff
approved these changes
Mar 16, 2026
kripken
reviewed
Mar 16, 2026
In emscripten-core#26381, the definition of this macro was moved into the `emscripten.h` header file, along with a warning if its used. This change removes this macro from the clang command line generated by emcc, reducing the differences between using `emcc` and using `clang -target=wasm32-emscripten` directly.
sbc100
force-pushed
the
remove_EMSCRIPTEN
branch
from
6e7b3bf to
769dc50
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #26381, the definition of this macro was moved into the
emscripten.hheader file, along with a warning if its used.This change removes this macro from the clang command line generated by emcc, reducing the differences between using
emccand usingclang -target=wasm32-emscriptendirectly.